Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LazyListScope.TopicBody LazyListScope.topicBody #834

Merged

Conversation

takahirom
Copy link
Contributor

@takahirom takahirom commented Jul 13, 2023

It appears that other extensions for LazyListScope start with a lowercase letter, but TopicBody starts with an uppercase letter. Therefore, I have changed it to start with a lowercase letter.

@hoc081098
Copy link
Contributor

hoc081098 commented Jul 13, 2023

extensions which start with lowercase are not Composables.
Composables emitting UI elements should start with uppercase letter.
See ColumnScope.AnimatedVisibility for example

@hoc081098
Copy link
Contributor

It is better to rename userNewsResourceCard to UserNewsResourceCard

@takahirom
Copy link
Contributor Author

Thanks for the suggestion, @hoc081098. However, 'LazyListScope.topicBody' is not a Composable, so it should start with a lowercase letter as per standard Kotlin functions.

Copy link
Contributor

@alexvanyo alexvanyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up to be consistent!

@mmoczkowski mmoczkowski merged commit b6459d4 into android:main Aug 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants